Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

revert: add scrollLeftTop for sheet snapshot #2398

Merged
merged 1 commit into from
Jun 3, 2024
Merged

revert: add scrollLeftTop for sheet snapshot #2398

merged 1 commit into from
Jun 3, 2024

Conversation

lumixraku
Copy link
Contributor

Reverts #2348

@codecov Codecov
Copy link

codecov bot commented Jun 3, 2024

Codecov Report

Attention: Patch coverage is 13.51351% with 128 lines in your changes are missing coverage. Please review.

Project coverage is 27.07%. Comparing base (38d8003) to head (7446ffc).

Files Patch % Lines
packages/engine-render/src/viewport.ts 0.00% 50 Missing ⚠️
...ers/render-controllers/scroll.render-controller.ts 0.00% 20 Missing ⚠️
...ers/render-controllers/freeze.render-controller.ts 0.00% 12 Missing ⚠️
...s/sheets-ui/src/services/scroll-manager.service.ts 59.25% 11 Missing ⚠️
.../engine-render/src/components/sheets/interfaces.ts 0.00% 9 Missing ⚠️
packages/sheets-ui/src/common/utils.ts 0.00% 3 Missing ⚠️
...ui/src/controllers/doc-editor-bridge.controller.ts 0.00% 2 Missing ⚠️
packages/engine-render/src/basics/scroll-xy.ts 0.00% 2 Missing ⚠️
...ets-ui/src/commands/commands/set-scroll.command.ts 0.00% 2 Missing ⚠️
...ets-ui/src/commands/operations/scroll.operation.ts 0.00% 2 Missing ⚠️
... and 14 more
Additional details and impacted files 
@@            Coverage Diff             @@
##              dev    #2398      +/-   ##
==========================================
- Coverage   27.07%   27.07%   -0.01%     
==========================================
  Files        1647     1647              
  Lines       83085    83012      -73     
  Branches    17221    17200      -21     
==========================================
- Hits        22495    22474      -21     
+ Misses      60590    60538      -52

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lumixraku lumixraku changed the title Revert "feat: add scrollLeftTop for sheet snapshot" revert "feat: add scrollLeftTop for sheet snapshot" Jun 3, 2024
@lumixraku lumixraku changed the title revert "feat: add scrollLeftTop for sheet snapshot" revert: add scrollLeftTop for sheet snapshot Jun 3, 2024
@lumixraku lumixraku merged commit 1e5c40c into dev Jun 3, 2024
9 of 11 checks passed
@lumixraku lumixraku deleted the revert-2348-feat/add-scrollLeftTop-sheet-snapshot branch June 3, 2024 08:01
@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 3, 2024

View Deployment

#9346474891

🥐 🍔 🥓 🥗 🥘 🌯 🍚 🍛 🍖 🍭 🍧 🍝 🥪 🥖 🍪
Still cooking, please come back later
🥙 🥮 🥨 🌭 🍦 🍙 🍕 🍰 🍮 🍜 🍡 🍱 🍿 🍕 🥟

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Dushusir Dushusir Dushusir approved these changes

@DR-Univer DR-Univer Awaiting requested review from DR-Univer

@jikkai jikkai Awaiting requested review from jikkai jikkai is a code owner

@Jocs Jocs Awaiting requested review from Jocs Jocs is a code owner

@wzhudev wzhudev Awaiting requested review from wzhudev wzhudev is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lumixraku @Dushusir